[CLOSED] Use constants for keyCodes

[core-ai-bot]

Issue by tvoliter
Thursday Jul 12, 2012 at 20:31 GMT
Originally opened as adobe/brackets#1241

---

Most of Brackets code that looks at the keyCode member of an event compares it against the keyCode number. Brackets could would be more readable if keycode constants were used instead.

References regarding constants and keyCodes
http://www.javascripter.net/faq/keyeventconstantsfirefox.htm
http://stackoverflow.com/questions/1465374/javascript-event-keycode-constants

[core-ai-bot]

Comment by peterflynn
Wednesday Jul 18, 2012 at 20:29 GMT

---

There's more of this in the unit tests now too... see the tests added by pull #1273, for example.

[core-ai-bot]

Comment by couzteau
Tuesday Aug 21, 2012 at 06:13 GMT

---

Hi brackets people. Looking into fixing this issue- Jochen

[core-ai-bot]

Comment by couzteau
Friday Aug 31, 2012 at 23:55 GMT

---

This is an easy fix but I wonder what the preferred place to define key constants would be. Do you want them in utils.Globals.js?

[core-ai-bot]

Comment by couzteau
Friday Aug 31, 2012 at 23:58 GMT

---

I suppose a better place might be to put constants into a KeyEvent class in utils? Thanks for a quick comment.

[core-ai-bot]

Comment by redmunds
Saturday Sep 01, 2012 at 21:36 GMT

---

Joschen, Thanks for taking this on. I marked it as "Fix in Progress". Yes, I think a KeyEvent module in utils is perfect.

[core-ai-bot]

Comment by couzteau
Sunday Sep 09, 2012 at 05:49 GMT

---

Pull request pending.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Sep 12, 2012 at 22:49 GMT

---

FBNC to@jasonsanjose

[core-ai-bot]

Comment by jasonsanjose
Thursday Oct 18, 2012 at 17:43 GMT

---

Confirmed fixed by pull request #1583.