-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Php Tooling Extensions Using LSP Framework #11969
Comments
Comment by shubhsnov Another thing to note: To test the validation logic against PHP5 and PHP7. Both should give different results, based on syntax. |
Comment by shubhsnov
|
Comment by shubhsnov
Same for completion resolve. |
Comment by niteskum
are we sure we have to include this in code hints.??, There might be some reason lsp server is not giving these variables as hints. |
Comment by shubhsnov
Get this resolved. My take is that most of these appear to quite common globals. It would be good to have. |
Comment by niteskum
correct me if my understanding is wrong. |
Comment by shubhsnov
Quoting from the actual specification here :
In Brackets we only have one project root, so workspace and project are synonymous. This way we can piggyback on the client capability "workspaceFolders", to change project root. I've done so in the default capabilities. A change in the project root can thus be translated as an addition of a folder and removal of a folder from a workspace which only has one folder. So quoting again:
I believe the reason we have both "rootUri" and "workspaceFolders" in the specification is because of backward compatibility. Earlier the servers didn't support multiple workspace folders, and separate clients had to be created per workspace folder manually in the extension. |
Comment by niteskum
Php server does not support WorkspaceFolders change Notification. so this can not be tested with Php client. so I am not using this in PHP client. we should not ship any feature without having tested. instead I have used servercapabilities.definitionProvider in PHP client this flag is true if Language Server support "go to definition". PHP Server support so i have used this PHP client. |
Comment by shubhsnov
|
Comment by niteskum
If we are going to use this event , then in initialize function we should also send workspaceFolders which is root_path, this require a change in core side in initialize function. |
Comment by niteskum
For LSP server to work we need PHP 7, with PHP 5 LSP server will not work |
Comment by niteskum
fixed |
Comment by shubhsnov
|
Comment by shubhsnov LGTM 👍 💯 |
Comment by swmitra Please resolve the conflicts |
Comment by niteskum
resolved conflicts in strings.js |
Comment by shubhsnov
|
Issue by niteskum
Wednesday Mar 20, 2019 at 07:22 GMT
Originally opened as adobe/brackets#14671
Language Server Client Extension using the https://github.com/felixfbecker/php-language-server
Requirements:
Installation:
npm install
Set the following preferences in
to configure the extension:
niteskum included the following code: https://github.com/adobe/brackets/pull/14671/commits
The text was updated successfully, but these errors were encountered: