Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Proper fix for "Show in OS" for Linux. #311

Open
core-ai-bot opened this issue Aug 17, 2021 · 3 comments
Open

[CLOSED] Proper fix for "Show in OS" for Linux. #311

core-ai-bot opened this issue Aug 17, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by radorodopski
Sunday Oct 19, 2014 at 22:53 GMT
Originally opened as adobe#477


Proper fix for "Show in OS" for Linux.

Now using an IPC method call (FileManager1.ShowItems) to show the file (highlighted) in its directory.
Also updated the appshell.gyp file.
Using the new DBus bindings which are provided by the GLib library (requires libglib-2.0 version 2.26 and up), so this no longer requires the old binding library (libdbus-glib-1).

If for some reason the above solution fails, the fallback behavior is to just open the directory containing the file (without the file being highlighted). This is done by calling gtk_show_uri() on the file's parent directory.

This is for https://trello.com/c/RF1ddQGK/898-linux-show-in-os-for-selected-file


radorodopski included the following code: https://github.com/adobe/brackets-shell/pull/477/commits

@core-ai-bot
Copy link
Member Author

Comment by radorodopski
Tuesday Oct 21, 2014 at 19:29 GMT


Please note that this is (IMO) a more robust solution than PR adobe#473

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Thursday Oct 23, 2014 at 22:57 GMT


Looks good to me. Would you mind signing the CLA http://dev.brackets.io/brackets-contributor-license-agreement.html? This is required for us to accept contributions. Thanks

@core-ai-bot
Copy link
Member Author

Comment by radorodopski
Friday Oct 24, 2014 at 03:29 GMT


Sure, I thought I signed that more than a year ago but maybe I'm mistaken.
I just signed the CLA. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant