[CLOSED] Implement node-module add-on for native Windows file watching

[core-ai-bot]

Issue by bchintx
Wednesday Jan 29, 2014 at 17:41 GMT
Originally opened as adobe#413

---

Fixes brackets issue #6551- "[File Watchers] Can not externally rename a directory with subfolders on Windows"

Requires associated pull request #6686 from brackets repo.

Calling a native node-module add-on in Windows requires that the node process be named "node.exe", rather than our renamed "Brackets-node.exe". This change reverts our previous renaming so that we ship with "node.exe" instead.

NOTE: this pull request against the release branch replaces the earlier PR #412 against master.

---

bchintx included the following code: https://github.com/adobe/brackets-shell/pull/413/commits

[core-ai-bot]

Comment by bchintx
Wednesday Jan 29, 2014 at 17:50 GMT

---

I've reviewed Jeff's changes and they look great. I'm fine with merging this change just as soon as PR #6686 is reviewed and ready to merge.

[core-ai-bot]

Comment by redmunds
Thursday Jan 30, 2014 at 21:08 GMT

---

I see more references to "Brackets-node" when I search brackets-shell:

  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj(406):    <CustomBuild Include="deps\node\Brackets-node.exe">
  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj(408):      <Command>call mkdir &quot;$(OutDir)&quot; 2&gt;nul &amp; set ERRORLEVEL=0 &amp; copy /Y &quot;deps\node\Brackets-node.exe&quot; &quot;$(OutDir)Brackets-node.exe&quot;</Command>
  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj(409):      <Message>Copying deps/node/Brackets-node.exe to $(OutDir)\Brackets-node.exe</Message>
  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj(410):      <Outputs>$(OutDir)\Brackets-node.exe</Outputs>
  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj.filters(31):    <None Include="deps\node\Brackets-node.exe">
  C:\Users\redmunds\github\brackets-shell\deps\cef\Release\dev\src\filesystem\impls\appshell\node\FileWatcherDomain.js(52): * the fsevents module is compiled by default for x86-64, but the Brackets-node
  C:\Users\redmunds\github\brackets-shell\Release\dev\src\filesystem\impls\appshell\node\FileWatcherDomain.js(52): * the fsevents module is compiled by default for x86-64, but the Brackets-node

UPDATE: Sorry, I should have cleaned that up before I pasted it in.

[core-ai-bot]

Comment by bchintx
Thursday Jan 30, 2014 at 21:56 GMT

---

@JeffryBooher did you want to respond to @redmunds comment? My response would be that we don't need to change all name instances since this is a Windows-only (and possibly a temporary) fix.

[core-ai-bot]

Comment by redmunds
Thursday Jan 30, 2014 at 22:12 GMT

---

Sorry, I pasted that list before I cleaned it up. The only references I'm concerned about are the ones in Brackets.vcxproj

[core-ai-bot]

Comment by JeffryBooher
Thursday Jan 30, 2014 at 22:56 GMT

---

@redmunds did you run grunt setup?

[core-ai-bot]

Comment by redmunds
Thursday Jan 30, 2014 at 23:46 GMT

---

No. That was it.