fix: return undefined if date format is not valid #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen cases in our logs with parsing exif data of photos from early 2000 where the library throws 'TypeError: Cannot read property 'split' of undefined'. The only place I could find where this error could be thrown should be fixed with this commit. Added a test that fails without this fix.
|
Thank you! BTW, I'm mostly using this for my hobby project, but I plan to replace it with potentially a faster and more reliable lib: bpatrik/pigallery2#277 (comment) Potentially exifr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen cases in our logs with parsing exif data of photos from early 2000' where this library throws
'TypeError: Cannot read property 'split' of undefined'.The only place I could find where this error could be thrown should be fixed with this commit.
Added a test that fails without this fix.
Unfortuneatly I don't have access to the original photos that caused the error. I