Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Hinting #603

Open
cflynn3 opened this issue Nov 23, 2022 · 1 comment
Open

Add Type Hinting #603

cflynn3 opened this issue Nov 23, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@cflynn3
Copy link
Collaborator

cflynn3 commented Nov 23, 2022

Currently importing RESQPY into a python file in another project and running the Mypy type checker generates a series of errors: error: Skipping analyzing "resqpy": module is installed, but missing library stubs or py.typed marker [import]. This is because Mypy cannot detect the types present in RESQPY due to a lack of type hints.

@cflynn3 cflynn3 added the bug Something isn't working label Nov 23, 2022
@andy-beer
Copy link
Contributor

I'm not sure we should regard this as a bug. We considered using type hints quite a while back and concluded that the value they would add did not justify the time and effort to add them throughout resqpy. I'm therefore going to relabel this as an enhancement.

@andy-beer andy-beer added enhancement New feature or request and removed bug Something isn't working labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants