Hi from Julie, and someone code review my first ever github pull request? #93
julie-mindcapers
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi, my name is Julie. I've been a TastyWorks user for a year or so and a Jill of All Things code for a long, long time. I just created a pull request to fix my situation where I have multiple TW accounts but the first one in the list is closed.
While I am far from a dev newbie, this is my first github contribution, though I've contributed MediaWiki extentions in the far and distant past. I am also a python newbie and unaware of where you want to go with this architecturally. The little function I added might be better in a utility or in the TradingAccount class, but I didn't want to presume nor overstep.
Now, if someone could give me a quick "here's how to retrieve a quote every minute" so I can implement the smart ticker I've been craving, that would be awesomesauce. :)
Beta Was this translation helpful? Give feedback.
All reactions