Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designing Class Diagram: Group #56

Closed
cisel-zumbul opened this issue Apr 6, 2023 · 3 comments
Closed

Designing Class Diagram: Group #56

cisel-zumbul opened this issue Apr 6, 2023 · 3 comments
Assignees
@alperen-bircak @cisel-zumbul
Labels
Priority: High Issues that require immediate attention and should be addressed as soon as possible. Status: Done Issues that have been completed. Type: Design Issues related to the design or layout of the project.

Comments

@cisel-zumbul
Copy link
Contributor

Description

The class diagrams are shared among the team members, since we worked on groups together so far, we will design the class diagram of Groups.

👮‍♀️ Reviewer

Bilal Atım

⏰ Deadline

07.04.2023
@cisel-zumbul cisel-zumbul added Priority: High Issues that require immediate attention and should be addressed as soon as possible. Type: Design Issues related to the design or layout of the project. Status: Assigned Issues that have been assigned to someone to work on. labels Apr 6, 2023
@cisel-zumbul cisel-zumbul added Status: In Progress Issues that are currently being worked on. and removed Status: Assigned Issues that have been assigned to someone to work on. Status: In Progress Issues that are currently being worked on. labels Apr 6, 2023
@bilalatim
Copy link
Contributor

bilalatim commented Apr 7, 2023 •
edited
Loading

I reviewed the Group class diagram you prepared. Nice work, it has almost everything to meet our requirements. I just want to ask, is it possible to add isPrivate attribute instead of using tags for private groups?

@cisel-zumbul
Copy link
Contributor Author

Actually, we had designed the class so that privacy of the groups are checked via Membership Policy attribute instead of using tags. In this case, we also won't be needing a isPrivate attribute.

@cisel-zumbul
Copy link
Contributor Author

Our class diagram is reviewed by team members and approved. Therefore I'm closing this issue.

@cisel-zumbul cisel-zumbul added Status: Done Issues that have been completed. and removed Status: In Progress Issues that are currently being worked on. labels Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alperen-bircak alperen-bircak

@cisel-zumbul cisel-zumbul

Labels
Priority: High Issues that require immediate attention and should be addressed as soon as possible. Status: Done Issues that have been completed. Type: Design Issues related to the design or layout of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alperen-bircak @cisel-zumbul @bilalatim