Skip to content
This repository has been archived by the owner on Mar 30, 2019. It is now read-only.

Limit users access to other profile information #134

Closed
ghost opened this issue Nov 20, 2018 · 3 comments
Closed

Limit users access to other profile information #134

ghost opened this issue Nov 20, 2018 · 3 comments
Assignees
Labels
Back-End Status: Wont Fix This will not be worked on

Comments

@ghost
Copy link

ghost commented Nov 20, 2018

Limit users access to other profile information

A user (let's say user_id = 58) can access to all other users and their profile information by changing the id like http://cultidate.herokuapp.com/api/user/59

I am not sure if we talked about this before but I think it shouldn't return all the information for other users. We can either return a simpler response with name, surname, and profile picture or do not return any info at all.

@ghost ghost added the Back-End label Nov 20, 2018
@cerob cerob added this to the Milestone #2 (CmpE451) milestone Nov 26, 2018
@cerob cerob self-assigned this Nov 26, 2018
@cerob
Copy link
Member

cerob commented Nov 26, 2018

It is doable, but at this scale, we don't need such feature in my opinion since not only it requires extra effort for backend but also makes frontend's tasks complicated.

@cerob cerob added the Status: Wont Fix This will not be worked on label Nov 26, 2018
@mertakozcan
Copy link
Contributor

I think that request will be used when a user visits another user's profile, so we have to return some information. Also, we planned the platform such that all profiles are public, since there is no such feature as 'add friend' etc. Maybe, we can filter out some of the fields in the future if there is a problem with the response data, but it doesn't seem like a priority at this point if you don't have any other arguments.

@mertakozcan
Copy link
Contributor

@mstfalp If we're on the same page, we can close the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Back-End Status: Wont Fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants