Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SDK for building Go binaries #19

Closed
jahkeup opened this issue Feb 27, 2020 · 1 comment
Closed

Use SDK for building Go binaries #19

jahkeup opened this issue Feb 27, 2020 · 1 comment
Assignees

Comments

@jahkeup
Copy link
Member

jahkeup commented Feb 27, 2020

Issue or Feature Request:

The build process for the update operator should use the same Go toolchain used throughout Bottlerocket.

This can be accomplished by subbing in the SDK container where the golang:N.N image was being used before. The license scanner (#6) should also use this image when collecting the modules into the to-be-scanned vendor/ directory.

Suggested Solution

The "golang" image can be provided as an ARG to the build commands (as is proposed in #6 for other uses - see Dockerfile.licenses). I was able to make a set of changes to do this in short order (and still support docker build -t neio:latest . at the root). Here's a gist with the set of changes.

@jahkeup jahkeup self-assigned this Feb 27, 2020
@jahkeup
Copy link
Member Author

jahkeup commented Feb 27, 2020

See bottlerocket-os/bottlerocket#791 for a similar change made in setting up source inputs for bottlerocket's included Go binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant