Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(distributed): canceling a task that is not handled locally waits for the task to be canceled #180

Merged
merged 11 commits into from
Feb 22, 2022

Conversation

franklevasseur
Copy link
Member

@franklevasseur franklevasseur commented Feb 21, 2022

in a cluster setup, wait for the instance that has the training to cancel it before returning from POST train/:modelId/cancel

@franklevasseur franklevasseur marked this pull request as draft February 21, 2022 20:04
…181)

* split e2e in 3 different gh jobs

* attempt2 at fixing e2e

* attempt3 at fixing e2e

* attempt4 at fixing e2e

* added ugly console logging to better debug whats up

* attempt5 at fixing e2e

* attempt6 at fixing e2e

* attempt7 at fixing e2e

* attempt8 at fixing e2e

* attempt9 at fixing e2e

* attempt10 at fixing e2e

* rm console logs

* slight refactor of e2e gh worflow
@franklevasseur franklevasseur changed the title fix(distributed): task cancelation waits for instance to answer fix(distributed): canceling a task that is not handled locally waits for the task to be canceled Feb 22, 2022
@franklevasseur franklevasseur marked this pull request as ready for review February 22, 2022 16:33
@franklevasseur franklevasseur merged commit 98afa80 into hints Feb 22, 2022
@franklevasseur franklevasseur deleted the fl_fix_distributed_cancel branch March 23, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant