Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze + Windows 7 + Node 6.8.0+ = bug #129

Closed
xdghcnt opened this issue Nov 10, 2016 · 5 comments
Closed

Freeze + Windows 7 + Node 6.8.0+ = bug #129

xdghcnt opened this issue Nov 10, 2016 · 5 comments

Comments

@xdghcnt
Copy link

xdghcnt commented Nov 10, 2016

New behaviour of Node Path nodejs/node#8541 (comment) сauses ENOENT error.
"C:Dir1/Dir2" passed to mkdirSync here:
https://github.com/borschik/borschik/blob/master/lib/freeze.js#L437

@blond
Copy link
Member

blond commented Nov 16, 2016

It is reproduced on all Node.js versions or only 6.x?

I tried the following code (launched not in Windows):

"C://Dir1/Dir2".split(path.sep); // [ 'C:', '', 'Dir1', 'Dir2' ]

path.join('C:', '', 'Dir1', 'Dir2'); // 'C:/Dir1/Dir2'

It works the same with Node.js 4 and Node.js 6.

In nodejs/node#8541 I see that they are talking about the path.resolve but not about the path.join.

Could you tell me which path value in this string.

@xdghcnt
Copy link
Author

xdghcnt commented Nov 16, 2016

On versions since 6.8.
My path is ok.
Actually this is what happens:

path.join('', 'C:'); // C:.
path.join('C:.', 'Dir1'); // C:Dir1
path.join('C:Dir1', 'Dir2'); // C:Dir1/Dir2

@tsofist
Copy link

tsofist commented Dec 2, 2016

any updates?

@ghost
Copy link

ghost commented Dec 14, 2016

Any news? Will it be fixed?

@tsofist
Copy link

tsofist commented Jan 10, 2017

Anybody home? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants