Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ink player won’t show any content if there’s an out of content warning on first line #14

Open
joningold opened this issue May 9, 2023 · 2 comments

Comments

@joningold
Copy link

The source

=== intro 
Hello! ```

Isn’t good ink, but at the moment it generates no player output at all, instead of the inky behaviour of output + warning. This might be significant for beginner users following early snippets from the documentation who might not know about -> DONE, and also might not feel confident exploring the “compiler” tab on Borogrove.
@juhana
Copy link
Contributor

juhana commented May 9, 2023

That's a tricky issue to solve as a special case because the editor doesn't really know when the story output is empty. Apart from parsing the compiler output and highlighting lines in the code like in Inky, I'm thinking maybe having the compiler warnings pop up in the main view? A mockup included here below. Just thinking out loud at this point.

editor

@joningold
Copy link
Author

I think having that for run time issues makes a lot of sense since arguably they are "part of the flow".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants