Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to fsync or not to fsync... #10

Closed
ThomasWaldmann opened this issue Aug 10, 2024 · 2 comments
Closed

to fsync or not to fsync... #10

ThomasWaldmann opened this issue Aug 10, 2024 · 2 comments

Comments

@ThomasWaldmann
Copy link
Member

From cr1901 on IRC:

bench script I used (notice the islice):

http://gopher.wdj-consulting.com:70/paste/eaf1103b-adbe-48f0-bb3a-34c65bc766a1.txt

Profile with fsync: http://gopher.wdj-consulting.com:70/paste/results-128k-fsync.txt

Profile with fsync removed: http://gopher.wdj-consulting.com:70/paste/results-128k-no-fsync.txt

TL;DR... no fsync is 26 times faster.
@ThomasWaldmann
Copy link
Member Author

Quite a speed impact, so do we have any other options besides just not syncing?

I read some stuff about fs write barriers, but did not find anything about how to use that.

ThomasWaldmann added a commit that referenced this issue Aug 10, 2024
@ThomasWaldmann
posixfs: don't fsync by default, see #10
c4403a3
ThomasWaldmann added a commit that referenced this issue Aug 10, 2024
@ThomasWaldmann
Merge pull request #11 from borgbackup/fsync
de6c240 
posixfs: don't fsync by default, see #10
@ThomasWaldmann
Copy link
Member Author

#11 added do_fsync=False parameter for posixfs backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThomasWaldmann