Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax for FJSX15 does not do auto closing tags for jsx #24

Closed
psyrendust opened this issue Nov 28, 2017 · 8 comments
Closed

Syntax for FJSX15 does not do auto closing tags for jsx #24

psyrendust opened this issue Nov 28, 2017 · 8 comments

Comments

@psyrendust
Copy link

Syntax for FJSX15 does not do auto closing tags for jsx, but it does for HTML 5.

I would expect to get the same type of auto close/auto complete on triggers for jsx files as I would for html files.

kapture 2017-11-28 at 15 34 00

@borela
Copy link
Owner

borela commented Nov 29, 2017

I added a command to the branch hotfix/close-jsx-tag, can you check if it solved the issue?

@psyrendust
Copy link
Author

No, that didn't seem to work.

@borela
Copy link
Owner

borela commented Nov 29, 2017

I believe I finally found the issue, there were scope voids in new line characters, I sent some commits which should fix issue.

Please update and check the branch hotfix/close-jsx-tag again to see if it is working on your machine.

@psyrendust
Copy link
Author

The change you made in 0d527ee did the trick. I was able to autocomplete html and custom tags when typing </.

@borela
Copy link
Owner

borela commented Nov 30, 2017

Released the patch on the master branch.

@borela borela closed this as completed Nov 30, 2017
@psyrendust
Copy link
Author

I just wanted to confirm that the public release works. Thanks for your help and quick response!

@borela
Copy link
Owner

borela commented Jan 14, 2018

Regression, the new syntax system fixed lots of issues, but this behavior is back, I am fixing this as soon as possible as it is affecting my workflow too.

@borela
Copy link
Owner

borela commented Jan 14, 2018

@borela borela closed this as completed Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants