Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot regex char class scoped as a string #180

Closed
YuriGor opened this issue Oct 15, 2018 · 4 comments
Closed

dot regex char class scoped as a string #180

YuriGor opened this issue Oct 15, 2018 · 4 comments
Labels

Comments

@YuriGor
Copy link

YuriGor commented Oct 15, 2018

Look at qq.+
dot colored as a string, not as regex selector.

var reg = /q[qwerty]\.qq.+s{1,2}\d\s/g;
@borela borela added the bug label Oct 15, 2018
@borela
Copy link
Owner

borela commented Oct 15, 2018

I could do like the builtin syntax and color it as constant.other.character-class, would that be fine? Do you know a better scope for this case?

@YuriGor
Copy link
Author

YuriGor commented Oct 15, 2018

i am total noob in the sphere of syntax highlighting and such things,
but may be you need to same scope as used for other selectors like \d \s \W and soon
In native JS/monokai this entries colored with purple color
image

@borela
Copy link
Owner

borela commented Oct 15, 2018

I used the same scope as the one being used by the builtin syntax; https://github.com/borela/naomi/releases/tag/v4.2.7

@borela borela closed this as completed Oct 15, 2018
@YuriGor
Copy link
Author

YuriGor commented Oct 15, 2018

Tested, works flawlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants