Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(b-link): convert functional component to regular component (closes #3634) #3637

Merged
merged 37 commits into from
Jul 8, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 8, 2019

Describe the PR

Convert b-link to a regular component from a functional component.

When users have a large number of components, which are derived from b-link (b-dropdown-item, b-button, etc), re-rendering can take performance hits due to the re-computation of the event handlers on each render.

Closes #3634

To do:

  • updated tests

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe): performance

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse changed the title feat(b-link): convert functional component to regular component perf(b-link): convert functional component to regular component Jul 8, 2019
@tmorehouse tmorehouse changed the title perf(b-link): convert functional component to regular component perf(b-link): convert functional component to regular component (closes #3634) Jul 8, 2019
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #3637 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3637      +/-   ##
==========================================
- Coverage   99.26%   99.26%   -0.01%     
==========================================
  Files         224      224              
  Lines        4333     4326       -7     
  Branches     1234     1231       -3     
==========================================
- Hits         4301     4294       -7     
  Misses         26       26              
  Partials        6        6
Impacted Files Coverage Δ
src/utils/router.js 100% <100%> (ø) ⬆️
src/components/link/link.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c8ae9...1403498. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 July 8, 2019 18:39
@tmorehouse tmorehouse marked this pull request as ready for review July 8, 2019 21:02
@tmorehouse tmorehouse merged commit d3641ba into dev Jul 8, 2019
@tmorehouse tmorehouse deleted the issue/3634 branch July 8, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b-dropdown performance problem since RC12
2 participants