fix(tab): don't use aria-expanded on the panel
#3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm a screen reader user, and the existence of `aria-expanded="true"` on the panel doesn't make much sense to me and isn't visible in any ARIA examples I've examined. This removes the attribute and updates the spec.
Codecov Report
@@ Coverage Diff @@
## dev #3143 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 212 212
Lines 3874 3874
Branches 1154 1154
=======================================
Hits 3841 3841
Misses 26 26
Partials 7 7
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #3143 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 212 212
Lines 3874 3874
Branches 1154 1154
=======================================
Hits 3841 3841
Misses 26 26
Partials 7 7
Continue to review full report at Codecov.
|
tmorehouse
approved these changes
Apr 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a screen reader user, and the existence of
aria-expanded="true"on the panel doesn't make much sense to me and isn't visible in any ARIA examples I've examined. This removes the attribute and updates the spec.