-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: temporary fix for validation icon positioning (Closes #2599) #2607
Conversation
Temporary fix for cssnano bug: cssnano/cssnano#712 "Fixed" by moving center to last value in background-position property Bug will/may affect Nuxt.JS users #2599
Codecov Report
@@ Coverage Diff @@
## dev #2607 +/- ##
=======================================
Coverage 70.47% 70.47%
=======================================
Files 172 172
Lines 3170 3170
Branches 923 923
=======================================
Hits 2234 2234
Misses 680 680
Partials 256 256 Continue to review full report at Codecov.
|
On hold to see when cssnano fixes the issue, and when Nuxt.JS updates dependencies to use new cssnano. |
It appears that it may be a while before cssnano is fixed: cssnano/cssnano#712 (comment) |
@tmorehouse Hmm, then let get this in. It isn't that much css and we can remove it anytime again. |
Description of Pull Request:
Temporary fix for cssnano bug: cssnano/cssnano#712
"Fixed" by moving center to last value in background-position property
Bug will/may affect Nuxt.JS users and BootstrapVue docs site
Closes #2599
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)and adding a new feature, break them into separate PRs if at all possible.
Conventional Commits naming convention (i.e.
"fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
"chore: fix typo in docs", etc). This is very important, as the
CHANGELOG
is generatedfrom these messages.
If new features/enhancement/fixes are added or changed:
package.json
for slot andevent changes)
keyboard only users? clickable items should be in the tab index, etc)
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:
suggestion issue first and wait for approval before working on it)