Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spinner): Pre-Release Bootstrap V4.2 spinners #2306

Merged
merged 33 commits into from
Dec 17, 2018
Merged

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Dec 16, 2018

Description of Pull Request:

Adds pre-release support for Boostrap V4.2 spinners via a new component <b-spinner>

Built as a Vue functional component, so it is very lightweight.

Conditionally includes spinner SCSS styles (will auto-exclude once V4.2 is released)

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #2306 into dev will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2306      +/-   ##
==========================================
+ Coverage   67.15%   67.24%   +0.09%     
==========================================
  Files         162      164       +2     
  Lines        3218     3227       +9     
  Branches      894      896       +2     
==========================================
+ Hits         2161     2170       +9     
  Misses        778      778              
  Partials      279      279
Impacted Files Coverage Δ
src/components/spinner/index.js 100% <100%> (ø)
src/components/spinner/spinner.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e21c0...3872b24. Read the comment docs.

@tmorehouse tmorehouse mentioned this pull request Dec 17, 2018
89 tasks
@tmorehouse tmorehouse changed the title feat(spinner): Bootstrap V4.2 spinners feat(spinner): Pre-Release Bootstrap V4.2 spinners Dec 17, 2018
@tmorehouse tmorehouse requested review from pi0 and mosinve December 17, 2018 06:45
@tmorehouse tmorehouse merged commit bf3994f into dev Dec 17, 2018
@tmorehouse tmorehouse deleted the tmorehouse/spinners branch December 17, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant