Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): flag most of bootstrap-vue as being side effect free #2268

Merged
merged 2 commits into from
Dec 11, 2018

Conversation

tmorehouse
Copy link
Member

Description of Pull Request:

Flag utils/array and utils/object as having sideEffects in package.json

To allow webpack4 to do better tree shaking.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Except for utils/array and utils/object
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #2268 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2268   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files         162      162           
  Lines        3182     3182           
  Branches      880      880           
=======================================
  Hits         2125     2125           
  Misses        777      777           
  Partials      280      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64bdf69...0f66993. Read the comment docs.

@tmorehouse tmorehouse requested review from pi0 and a team December 11, 2018 19:13
@tmorehouse
Copy link
Member Author

We might be able to re-write the two modules so that they don't have side effects, but we can wait for a future release for that.

@tmorehouse
Copy link
Member Author

Plus the two modules are rather small, so even though they will be fully included it shouldn't affect users final bundle size too much.

@tmorehouse tmorehouse merged commit 5a77532 into dev Dec 11, 2018
@tmorehouse tmorehouse deleted the tmorehouse/sideeffects branch December 11, 2018 19:34
@tmorehouse tmorehouse restored the tmorehouse/sideeffects branch December 11, 2018 21:51
@tmorehouse
Copy link
Member Author

Hmmm strange.. looks like this is causing issues in the docs for some reason

@tmorehouse
Copy link
Member Author

Reverting for now

tmorehouse added a commit that referenced this pull request Dec 11, 2018
@tmorehouse
Copy link
Member Author

Ah ha... its because webpack was filtering out the .css/. scss as they weren't marked in the side effects.

@pi0 pi0 mentioned this pull request Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants