Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace opencollective dependency with opencollective-postinstall #2067

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Replace opencollective dependency with opencollective-postinstall #2067

merged 1 commit into from
Oct 10, 2018

Conversation

leipert
Copy link
Contributor

@leipert leipert commented Oct 10, 2018

The opencollective dependency brings in a lot of unneeded packages into the dependency tree for essentially console.log at post install. On a fresh project, where we just habe bootstrap-vue as a dependency, it pulls in over 100 dependencies. The open collective project has an alternative dependency which does essentially the same thing without polluting the dependency tree: opencollective-postinstall

Output before:

screenshot 2018-10-10 at 10 04 29

Output after:

screenshot 2018-10-10 at 10 03 56

Dependency tree before/after:

# before
yarn list | wc -l
# yields 111

#after
yarn list | wc -l
# yields 15

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #2067 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2067   +/-   ##
=======================================
  Coverage   61.27%   61.27%           
=======================================
  Files         154      154           
  Lines        2887     2887           
  Branches      796      796           
=======================================
  Hits         1769     1769           
  Misses        802      802           
  Partials      316      316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d471502...d35f869. Read the comment docs.

This replaces the `opencollective` with `opencollective-postinstall`.
The latter has the same functionality when it comes to presenting users
with the message, but brings in 96 less dependencies.
@pi0 pi0 merged commit fa26882 into bootstrap-vue:dev Oct 10, 2018
@leipert leipert deleted the leipert/replace-opencollective branch October 10, 2018 08:54
shinrox added a commit to shinrox/bootstrap-vue that referenced this pull request Oct 26, 2018
* dev: (31 commits)
  feat(card): support left and right image placement (bootstrap-vue#1981)
  fix(collapse/toggle): "collapsed" class cleared when component updated (bootstrap-vue#2102)
  fix(form-file): Add validation of single file (bootstrap-vue#2028)
  chore(docs): minor update to the b-form-input docs
  chore(docs): Minor update to b-form-input docs
  feat(table): Add row-unhovered event (bootstrap-vue#1874)
  feat(table): Support contextmenu event binding for table rows (bootstrap-vue#2064)
  docs(table): fix minor typo (bootstrap-vue#2093)
  feat(table): Support sorting on nested object properties (bootstrap-vue#1868)
  perf(modal): optimize model.resetScrollbar, resolves bootstrap-vue#1831  (bootstrap-vue#1837)
  docs: Update images reference section (bootstrap-vue#1999)
  fix(observe-dom): fix comment typo (bootstrap-vue#2084)
  chore(modal): trivial word fix in comment (bootstrap-vue#2089)
  (docs): Fix grammer in Intro readme (bootstrap-vue#2092)
  fix(modal): prevent scrolling on .modal-content focus, fixes bootstrap-vue#1748 (bootstrap-vue#2060)
  feat(pagination):  added slots for first, prev, next, last, and ellipsis. Fixes bootstrap-vue#1870. (bootstrap-vue#1980)
  Handle state change on validated fields. (bootstrap-vue#1984)
  fix(docs): input group prepend slot typo (bootstrap-vue#2059)
  fix(dependencies): replace opencollective with opencollective-postintall (bootstrap-vue#2067)
  fix(docs): change b-input-group attribute 'left' to 'prepend' (bootstrap-vue#2017)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants