Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for type change in tommath #603

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Workaround for type change in tommath #603

merged 1 commit into from
Mar 4, 2024

Conversation

mborland
Copy link
Member

Closes: #602

@jzmaddock This is certainly not the most robust solution on earth, but I see that we check against similar deprecation macros elsewhere. They have no versioning macro so I can't think of a better solution.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (3c9ff4d) to head (5675c50).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #603   +/-   ##
=======================================
  Coverage     94.1%   94.1%           
=======================================
  Files          274     274           
  Lines        28563   28563           
=======================================
  Hits         26874   26874           
  Misses        1689    1689           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9ff4d...5675c50. Read the comment docs.

@jzmaddock
Copy link
Collaborator

Thanks Matt, this is about all we can do here I think.

@mborland mborland merged commit ffe506a into develop Mar 4, 2024
71 checks passed
@NAThompson NAThompson deleted the tommath branch March 4, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mp_radix_size pointer type incorrect in some versions of tommath
2 participants