Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce truncation in dec_float multiplication #585

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

ckormanyos
Copy link
Member

The purpose of this PR is to reduce truncation in cpp_dec_float's multiplication. It is based on some discussion in parts of #368.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e584f4f) 94.1% compared to head (73fb4d3) 94.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #585   +/-   ##
=======================================
  Coverage     94.1%   94.1%           
=======================================
  Files          273     273           
  Lines        28523   28523           
=======================================
  Hits         26835   26835           
  Misses        1688    1688           
Files Coverage Δ
include/boost/multiprecision/cpp_dec_float.hpp 94.0% <100.0%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e584f4f...73fb4d3. Read the comment docs.

@ckormanyos
Copy link
Member Author

Hi Matt (@mborland) I can configure the CodeCov Deltas. I'm a bit surprised that my trivial change led to such a decrease. I'll look into this.

Anyway, we dont want fails due to a small one, two percent delta. I can handle this on the weekend in the CodeCov Properties for this workspace.

@ckormanyos ckormanyos merged commit 878138a into develop Jan 19, 2024
71 checks passed
@ckormanyos ckormanyos deleted the reduce_dec_float_truncation branch January 19, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant