Fix for issue 845 #846
Merged
Fix for issue 845 #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid division by zero in special cases
This was referenced Oct 16, 2022
4 tasks
jzmaddock
reviewed
Oct 24, 2022
| @@ -86,7 +86,12 @@ namespace boost | |||
| } | |||
| pois *= i / l2; | |||
| beta += xterm; | |||
| xterm *= (a + i - 1) / (x * (a + b + i - 2)); | |||
|
|
|||
| if (a + b + i != 2) | |||
There was a problem hiding this comment.
Rather than putting an if inside the inner loop, it would be better to move calculation of xterm to the start of the loop: albeit it's inconvenient, and we have to be careful to get the algebra right ;)
Again this should wait till after the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid division by zero in special cases
xref: scipy/scipy#17101