fix unused abterm1 compile warnings #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, not sure how that crept in there.... merging. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
exp_sinh_detail.hppcontains an unconditionally unused variableabterm1that causes compile warnings. This issue was fixed for C++17 and above in #884 with the addition of theBOOST_MATH_MAYBE_UNUSEDmacro.This PR implements a direct fix that removes the warning for all C++ versions. It also removes the
BOOST_MATH_MAYBE_UNUSEDmacro as this is the only place it's used in the Boost (all libraries).