Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure Event Hub #1430

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Add Azure Event Hub #1430

merged 8 commits into from
Nov 17, 2023

Conversation

gonzalojaubert
Copy link
Contributor

@gonzalojaubert gonzalojaubert commented Sep 19, 2023 •
edited
Loading

Add Azure Event Hub

Update your index.ts to add new methods:

boosterProduceEventStream,
  boosterConsumeEventStream,

@ghost
Copy link

ghost commented Sep 19, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=5b0f5e54d7826c5d137fb6215c5423b21c2e59fa

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

❌ Oh no! Integration tests have failed

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=a41a5f2

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=c691af7

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@github-actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@gonzalogarciajaubert gonzalogarciajaubert marked this pull request as draft October 26, 2023 13:51
alvaroloes
alvaroloes reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@alvaroloes alvaroloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is amazing! Everything is very well thought 🏅

packages/framework-provider-azure/src/library/events-stream-consumer-adapter.ts Outdated Show resolved Hide resolved
...ages/framework-provider-azure-infrastructure/src/infrastructure/synth/terraform-event-hub.ts Outdated Show resolved Hide resolved
packages/framework-provider-azure/src/index.ts Outdated Show resolved Hide resolved
packages/framework-provider-azure/src/library/events-stream-producer-adapter.ts Outdated Show resolved Hide resolved
website/docs/10_going-deeper/azure-scale.mdx Show resolved Hide resolved
@gonzalogarciajaubert gonzalogarciajaubert marked this pull request as ready for review November 16, 2023 12:36
@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=a1f35da4f820b72d0fc14c025b722e4c44769555

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=a38a431

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@charlietfe charlietfe self-requested a review November 17, 2023 13:08
@gonzalogarciajaubert gonzalogarciajaubert merged commit 46181ee into boostercloud:main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzalogarciajaubert gonzalogarciajaubert gonzalogarciajaubert left review comments

@alvaroloes alvaroloes alvaroloes approved these changes

@charlietfe charlietfe charlietfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gonzalojaubert @gonzalogarciajaubert @charlietfe @alvaroloes