Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.3 syntax #82

Closed
isaacfreeman opened this issue Dec 1, 2017 · 1 comment
Closed

Ruby 2.3 syntax #82

isaacfreeman opened this issue Dec 1, 2017 · 1 comment

Comments

@isaacfreeman
Copy link

In the v1.0-v2.0 branch, the gemspec specifies Ruby version >=2.1.

However, app/models/solidus_avatax_certified/line.rb uses the safe navigation operator &. that was introduced in Ruby 2.3.
https://github.com/boomerdigital/solidus_avatax_certified/blob/v1.0-v2.0/app/models/solidus_avatax_certified/line.rb#L159

Possible solutions:

  1. Replace the &. with a try(...)
  2. Bump up the required Ruby version to 2.3
@dhonig
Copy link
Contributor

dhonig commented Dec 1, 2017

Thanks Isaac. I'd say that the simplest thing is to bump up the gem version, but perhaps may clients of this gem aren't ready to make that leap? Do you want to send us a PR for the try version? I think it will serve the community better to go with option 1 ( though I like option 2 better)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants