Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a CSS quirk in listing overview pages #2554

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Conversation

bobdenotter
Copy link
Member

Before:

Screenshot 2021-04-28 at 17 18 20

After:

Screenshot 2021-04-28 at 17 37 27

It would be better if it were dynamic, but that might have downsides as well (like, columns shifting). This fix makes it better, with low impact.

@I-Valchev
Copy link
Member

Neat, definitely much better already!

Have you tried it with text-overflow: ellipsis;? We already use that in a few places
https://github.com/bolt/core/search?q=ellipsis

@bobdenotter
Copy link
Member Author

I keep forgetting that support for that is now in all major browsers. 🤦

Updated PR!

Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice! Let's roll with this!

@I-Valchev I-Valchev merged commit 7608367 into 4.1 Apr 29, 2021
@I-Valchev I-Valchev deleted the fix/css-quirk-in-listing branch April 29, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants