Update _multiselect.scss (fine-tuning CSS)
#2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression that happened at some point after this had been fixed: bolt#1899
I-Valchev
reviewed
Feb 15, 2021
|
Ah, I think I'm the one to blame for that! #2283 What I wanted to do there is to remove the awkward empty space in the white field input itself, not between the items. So, I wanted to get rid of this:
I think this will solve it (hence my suggestion to your PR): &:not(:last-of-type) {
margin-bottom: 0.4rem;
}Do you agree @eduardomart ? |
|
Sounds good to me 👍 |
|
@eduardomart thanks, in that case I'm adding it to the PR. Let's see if the tests pass! |
bobdenotter
reviewed
Feb 15, 2021
bobdenotter
changed the title
_multiselect.scss (fine-tuning CSS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression that happened at some point after this had been fixed:
#1899