Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phpstan] remove invalid tmp dir + dependency on symfony container #1958

Merged
merged 1 commit into from
Oct 7, 2020
Merged

[phpstan] remove invalid tmp dir + dependency on symfony container #1958

merged 1 commit into from
Oct 7, 2020

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Oct 7, 2020 •
edited
Loading

Low hanging fruit cherry-pick from https://github.com/bolt/core/pull/1919/files

@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Oct 7, 2020 •
edited
Loading

CI fail is unrelated (random 2 jobs out 6 fail)

@TomasVotruba
Copy link
Contributor Author

Ready to merge ✔️

bobdenotter
bobdenotter approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've bumped Travis, and i'll merge this one in! Thanks! 👍

@bobdenotter bobdenotter merged commit 1c3ce02 into bolt:master Oct 7, 2020
@TomasVotruba TomasVotruba mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @bobdenotter