Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new bolt:reset-password CLI command to reset password #1937

Merged

Conversation

simongroenewolt
Copy link
Contributor

@simongroenewolt simongroenewolt commented Oct 3, 2020

Reset password command is in the documentation (https://github.com/bolt/docs/blob/4.0/docs/howto/resetting-a-password.md), but not in the code. This is a simple version. Differences to the documentation: you have to specify the username (e-mail not possible) and you get the option of specifying a password yourself.

…lt/docs/blob/4.0/docs/howto/resetting-a-password.md), but not in the code. This is a simple version. Differences to the documentation: you have to specify the username (e-mail not possible) and you get the option of specifying a password yourself.
@simongroenewolt
Copy link
Contributor Author

Reason to not implement username or email, but only username was to prevent having to specify what happens in edge-cases like someone having a username that is the same as someone else's email.

Copy link

@JKetelaar JKetelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my 2¢

@simongroenewolt
Copy link
Contributor Author

Ok, I've figured out how to run the coding style check locally - should have done that earlier.

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks, @simongroenewolt 👍

@bobdenotter bobdenotter merged commit db7ecf1 into bolt:master Oct 4, 2020
@simongroenewolt simongroenewolt deleted the feature/reset-password-command branch October 4, 2020 09:58
@bobdenotter bobdenotter changed the title reset password command is in the documentation (https://github.com/bo… Add new bolt:reset-password CLI command to reset password Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants