Update to Symfony 5

[bobdenotter]

Currently, Bolt 4 uses SF 4 components. We should bump these to v5.

• Replace Behat / MinkBrowserKitDriver with updated forks -> See Refactor to FriendsOfBehat/SymfonyExtension #1474
• Replace PagerFanta with BabDev/BabDevPagerfantaBundle
• Remove doctrine/doctrine-cache-bundle
• Fix deprecations in SF 4.4
• use error_controller under "framework", instead of exception_controller under "twig" -> See Use new Symfony Error Controller, instead of Twig's old one. #1477

[bobdenotter]

Behat / MinkBrowserKitDriver needs to be updated, but it seems work is underway:

minkphp/MinkBrowserKitDriver#142
Behat/Symfony2Extension#157

alternatively, see if we can use this (as is also used by Sylius):

https://github.com/FriendsOfBehat/MinkExtension

[bobdenotter]

Same for PagerFanta:

• Symfony 5 support sampart/WhiteOctoberPagerfantaBundle#224
• Fork here: https://github.com/BabDev/BabDevPagerfantaBundle

[bobdenotter]

Other findings:

We need to fix deprecations:

!!
!!  Fatal error: Uncaught TypeError: Argument 2 passed to Symfony\Component\DependencyInjection\ContainerBuilder::set() must be an object or null, array given, called in /foo/src/Kernel.php on line 95 and defined in /foo/vendor/symfony/dependency-injection/ContainerBuilder.php:484
!!  Stack trace:
!!  #0 /foo/src/Kernel.php(95): Symfony\Component\DependencyInjection\ContainerBuilder->set('bolt.config.gen...', Array)
!!  #1 /foo/src/Kernel.php(64): Bolt\Kernel->setBoltParameters(Object(Symfony\Component\DependencyInjection\ContainerBuilder), '/Users/bob/Site...')
!!  #2 /foo/vendor/symfony/framework-bundle/Kernel/MicroKernelTrait.php(118): Bolt\Kernel->configureContainer(Object(Symfony\Component\DependencyInjection\ContainerBuilder), Object(Symfony\Component\Config\Loader\DelegatingLoader))
!!  #3 /foo/vendor/symfony/dependency-injection/Loader/ClosureLoader.php(38): Bolt\Kernel->Symfony\Bundle\FrameworkBundle\Kernel in /foo/vendor/symfony/dependency-injection/ContainerBuilder.php on line 484
!!  PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Symfony\Component\DependencyInjection\ContainerBuilder::set() must be an object or null, array given, called in /foo/src/Kernel.php on line 95 and defined in /foo/vendor/symfony/dependency-injection/ContainerBuilder.php:484
!!  Stack trace:
!!  #0 /foo/src/Kernel.php(95): Symfony\Component\DependencyInjection\ContainerBuilder->set('bolt.config.gen...', Array)
!!  #1 /foo/src/Kernel.php(64): Bolt\Kernel->setBoltParameters(Object(Symfony\Component\DependencyInjection\ContainerBuilder), '/Users/bob/Site...')
!!  #2 /foo/vendor/symfony/framework-bundle/Kernel/MicroKernelTrait.php(118): Bolt\Kernel->configureContainer(Object(Symfony\Component\DependencyInjection\ContainerBuilder), Object(Symfony\Component\Config\Loader\DelegatingLoader))
!!  #3 /foo/vendor/symfony/dependency-injection/Loader/ClosureLoader.php(38): Bolt\Kernel->Symfony\Bundle\FrameworkBundle\Kernel in /foo/vendor/symfony/dependency-injection/ContainerBuilder.php on line 484

And remove doctrine/doctrine-cache-bundle:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for symfony/security-bundle ^5.1 -> satisfiable by symfony/security-bundle[v5.1.0, v5.1.1].
    - doctrine/doctrine-cache-bundle 1.4.0 requires symfony/doctrine-bridge ^3.4|^4.0 -> satisfiable by symfony/doctrine-bridge[v4.4.10].
    - doctrine/doctrine-cache-bundle 1.4.0 requires symfony/doctrine-bridge ^3.4|^4.0 -> satisfiable by symfony/doctrine-bridge[v4.4.10].
    - Conclusion: remove symfony/doctrine-bridge v4.4.10
    - Installation request for doctrine/doctrine-cache-bundle ^1.4 -> satisfiable by doctrine/doctrine-cache-bundle[1.4.0].

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In Configuration.php line 40:
!!
!!    Option "exception_controller" under "twig" must be null or unset, use "erro
!!    r_controller" under "framework" instead.
!!
!!
!!
Script @auto-scripts was called via post-update-cmd

[bobdenotter]

New one:

Fatal error: Uncaught Error: Class 'Symfony\Component\Debug\Debug' not found in /Users/bob/Sites/bolt/core/public/index.php:26 Stack trace: #0 {main} thrown in /Users/bob/Sites/bolt/core/public/index.php on line 26

[bobdenotter]

Making progress.. Seems the only blocker is now Behat: