Merge pull request #1349 from bolt/Add-length-attribute-for-title

Add length attribute for `|title` filter
bolt · May 4, 2020 · 3e519d3 · 3e519d3
2 parents 8671d5b + a807097
commit 3e519d3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/Entity/ContentExtrasTrait.php b/src/Entity/ContentExtrasTrait.php
@@ -31,7 +31,7 @@ public function getExtras(): array
         $content = $this;
 
         return array_filter([
-            'title' => $this->contentExtension->getAnyTitle($content),
+            'title' => $this->contentExtension->getAnyTitle($content, 80),
             'image' => $this->contentExtension->getImage($content, true),
             'excerpt' => $this->contentExtension->getExcerpt($content),
             'link' => $this->contentExtension->getLink($content),

diff --git a/src/Twig/ContentExtension.php b/src/Twig/ContentExtension.php
@@ -141,9 +141,9 @@ public function getFunctions(): array
         ];
     }
 
-    public function getAnyTitle(Content $content): string
+    public function getAnyTitle(Content $content, int $length = 120): string
     {
-        $title = $this->getTitle($content);
+        $title = $this->getTitle($content, '', $length);
 
         if (! empty($title)) {
             return $title;
@@ -153,7 +153,7 @@ public function getAnyTitle(Content $content): string
             $locales = $content->getDefinition()->get('locales');
 
             foreach ($locales as $locale) {
-                $title = $this->getTitle($content, $locale);
+                $title = $this->getTitle($content, $locale, $length);
 
                 if (! empty($title)) {
                     return $title;
@@ -164,7 +164,7 @@ public function getAnyTitle(Content $content): string
         return '';
     }
 
-    public function getTitle(Content $content, string $locale = ''): string
+    public function getTitle(Content $content, string $locale = '', int $length = 120): string
     {
         $titleParts = [];
 
@@ -184,9 +184,7 @@ public function getTitle(Content $content, string $locale = ''): string
             $titleParts[] = $value;
         }
 
-        $maxLength = 80; // Should we make this configurable, or is that overkill?
-
-        return Html::trimText(implode(' ', $titleParts), $maxLength);
+        return Html::trimText(implode(' ', $titleParts), $length);
     }
 
     public function guessTitleFields(Content $content): array