Added a skipFirst option to allow the first X requests to be discounted from the result calculations #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the skipFirst option for warmup delays
Added a skipFirst switch to allow the first X requests to be discounted from the results
bumped golangci-lint version, added results of go mod tidy
|
Hello, thanks for the PR. I see how this can be useful. Can you please add a test for the new options function, and also for the skipFirst functionality in Also it would be helpful to add the new |
added test for skipping first N
Added options test and some docs
added options tests
|
@bojand please re-review PR when you get a chance. The changes you requested have been made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new switch --skipFirst=X will skip the first X requests when doing the timing calculations and histogram. This helps in initial warm-up situations.
Example run:
With assistance from @michaelperel
Note one change was due to linting errors in the existing code-base.