Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Correct TLSClientIdentifier? #151

Open
JvB94 opened this issue Dec 18, 2024 · 1 comment
Open

[Feature Request]: Correct TLSClientIdentifier? #151

JvB94 opened this issue Dec 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@JvB94
Copy link

JvB94 commented Dec 18, 2024

Describe the feature / enhancement and how it would improve things

In https://github.com/bogdanfinn/tls-client/blob/master/cffi_dist/example_csharp/Requester.cs the default value for TlsClientIdentifier is FireFox110 that seems a bit diffrent to the default identifier who is used for all the other versions here.

I want to use Chrome 131 which identifier i have to use in the csharp one? Is it Chrome131 then?

Describe how your proposal will work, with code and/or pseudo-code

@JvB94 JvB94 added the enhancement New feature or request label Dec 18, 2024
@bogdanfinn
Copy link
Owner

@JvB94 here you can see all the built in tlsClientIdentifiers as strings.
https://github.com/bogdanfinn/tls-client/blob/master/profiles/profiles.go#L10

FireFox110 is not correct you are right. correct would be firefox_110

Afaik it will fallback to default profile if you supply anything which is not implemented. Default is currently Chrome131
https://github.com/bogdanfinn/tls-client/blob/master/profiles/profiles.go#L8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants