Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set difference is symmetrical difference. #88

Closed
AljoschaMeyer opened this issue May 6, 2019 · 1 comment
Closed

Set difference is symmetrical difference. #88

AljoschaMeyer opened this issue May 6, 2019 · 1 comment

Comments

@AljoschaMeyer
Copy link
Contributor

XyzSet::difference computes the symmetrical difference, not regular difference (aka relative complement). That was fairly surprising to me, it might be a good idea to document this more explicitly than only in the example.

If this was a deliberate choice of terminology, I'd be interested in hearing about the reasoning. Also, would you be open to adding XyzSet::relative_complement to the crate?

@bodil
Copy link
Owner

bodil commented May 9, 2019

It was deliberate only in the sense that I've recycled the method names from equivalent data structure impls in Haskell, so I couldn't tell you the actual reasoning behind them.

I'd be very happy to take PRs for any additional methods that make sense, and I don't see why this wouldn't. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants