Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "phase: early" filter on Test262+Prepack integration #126

Open
spectranaut opened this issue Sep 19, 2017 · 2 comments
Open

Add a "phase: early" filter on Test262+Prepack integration #126

spectranaut opened this issue Sep 19, 2017 · 2 comments

Comments

@spectranaut
Copy link

spectranaut commented Sep 19, 2017

For prepack's Test262 filtering

https://github.com/facebook/prepack/blob/master/scripts/test262-runner.js#L1142

  // Ignore phase: early tests because those are errors that babel should catch
  // not issues related to Prepack
  let phase_early = testFileContents.indexOf("  phase: early");
  let end_of_comment = testFileContents.indexOf("---*/");
  if (phase_early > 0 && phase_early < end_of_comment) return false;
@leobalter
Copy link

maybe this can be simplified by filtering the negative tests,

@leobalter leobalter added this to the test262-harness filters milestone Sep 19, 2017
@labond
Copy link

labond commented Oct 6, 2017

Per #125 we'll move this to backlog

@leobalter leobalter changed the title Add a "phase: early" filter on Test262-harness Add a "phase: early" filter on Test262+Prepack integration Oct 20, 2017
@leobalter leobalter self-assigned this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants