Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip history of the nvda-portable directory #10

Closed
gnarf opened this issue Mar 7, 2024 · 2 comments
Closed

Strip history of the nvda-portable directory #10

gnarf opened this issue Mar 7, 2024 · 2 comments

Comments

@gnarf
Copy link
Collaborator

gnarf commented Mar 7, 2024

There were a couple of big zip files committed here before switching to a cleaner approach to distributing these files in PR #8

We should use https://github.com/newren/git-filter-repo/ to clean these files out of the history: git-filter-repo --path nvda-portable --invert-paths should do it.

We should do this at a time when no open PR exist as the result will be a force push back to main - we can preserve old-main for a little bit in case of long term problems, but I don't think there will be any.

@jugglinmike
Copy link
Member

GitHub's "checkout" action sensibly defaults to a shallow clone, so the presence of an irrelevant 50-megabyte binary blob won't have a practical impact on CI performance. Persisting the file in the history might be a bit wasteful for folks who clone this repository manually, but I'm not certain that's sufficient motivation to perform this operation. We don't expect this repository to be cloned by many people, after all, and people may one day wish to accurately recreate the repository in its early state

@gnarf does that seem reasonable to you?

@gnarf
Copy link
Collaborator Author

gnarf commented Apr 23, 2024

Sure - but I think it's actually 3 or 4 different blobs as a new NVDA dropped and plugin updates etc

@gnarf gnarf closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants