Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Don't deactivate already inactive deployments #104

Merged
merged 5 commits into from
Jun 22, 2022
Merged

[BUGFIX] Don't deactivate already inactive deployments #104

merged 5 commits into from
Jun 22, 2022

Conversation

paullarsen-unlikely
Copy link
Contributor

#92 Mentions errors regarding deployments having the max number of statuses already set.

This PR avoids this from happening, by only setting the status if the status isn't already "inactive".

@bobheadxi
Copy link
Owner

Thank you for the contribution! I'll get this merged and released this week, but need to figure out why GitHub actions didn't run on this branch 🤔

@paullarsen-unlikely paullarsen-unlikely force-pushed the paul/fix-too-many-statuses-error branch from 9f992e1 to 58e01c0 Compare June 8, 2022 12:12
@paullarsen-unlikely paullarsen-unlikely mentioned this pull request Jun 8, 2022
Merged
@paullarsen-unlikely
Copy link
Contributor Author

Thank you for the contribution! I'll get this merged and released this week, but need to figure out why GitHub actions didn't run on this branch 🤔

@bobheadxi i believe this is due to the missing pull_request action in the pipeline.yaml. It's currently set to "push", which only works if its a push to a branch on THIS repo; since my repo is a fork, it doesnt count.

Hopefully fixed by #109?

bobheadxi
bobheadxi approved these changes Jun 11, 2022
View reviewed changes
Copy link
Owner

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@bobheadxi
Copy link
Owner

@paullarsen-unlikely There appear to be some formatting issues, do you mind fixing them? Thank you!

vhatsura
vhatsura reviewed Jun 14, 2022
View reviewed changes
Copy link

@vhatsura vhatsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paullarsen-unlikely , looks good. Can you run npm run prettier to fix formatting issues?

@paullarsen-unlikely
Copy link
Contributor Author

@bobheadxi Formatting has been fixed - sorry for the delay!

bobheadxi
bobheadxi approved these changes Jun 22, 2022
View reviewed changes
Copy link
Owner

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go, thank you :)

@bobheadxi
Copy link
Owner

Looks like integration tests don't work on forked PRs - might be something to look into @vhatsura !

@bobheadxi bobheadxi merged commit 9d4477f into bobheadxi:main Jun 22, 2022
@bobheadxi
Copy link
Owner

Integration tests look healthy in main: https://github.com/bobheadxi/deployments/runs/6996779510?check_suite_focus=true

@bobheadxi
Copy link
Owner

I've cut a release for this change: https://github.com/bobheadxi/deployments/releases/tag/v1.3.0

@vhatsura vhatsura mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobheadxi bobheadxi bobheadxi approved these changes

@vhatsura vhatsura vhatsura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paullarsen-unlikely @bobheadxi @vhatsura