Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top-level method names collide with other identifiers #18

Closed
bobg opened this issue Jul 1, 2023 · 0 comments · Fixed by #17
Closed

Top-level method names collide with other identifiers #18

bobg opened this issue Jul 1, 2023 · 0 comments · Fixed by #17
Labels
bug Something isn't working

Comments

@bobg
Copy link
Owner

bobg commented Jul 1, 2023

This change was erroneously flagged by modver as Major: bobg/subcmd#2

...because it added a new String method for one of the package's types, which ended up getting compared against the existing constant named String.
@bobg bobg added the bug Something isn't working label Jul 1, 2023
@bobg bobg mentioned this issue Jul 1, 2023
Merged
@bobg bobg closed this as completed in #17 Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix method-name collisions bobg/modver
1 participant
@bobg