Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitive major-version upgrades #10

Open
bobg opened this issue Dec 21, 2022 · 0 comments
Open

Transitive major-version upgrades #10

bobg opened this issue Dec 21, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@bobg
Copy link
Owner

bobg commented Dec 21, 2022

Seen in the wild (actual project names concealed to protect proprietary interests):

Module A exports function F that takes a *github.Client as an argument. Module B calls F.

Module A upgrades its go-github dependency from v47 to v48. Now F takes a *github.Client (a different type, because it's a different major version). Modver does not require a major-version upgrade in A, and B breaks.

@bobg bobg added the good first issue Good for newcomers label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant