Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocker] It's impossible to install with npm install on Windows. #10

Open
Steel5rat opened this issue Jan 30, 2024 · 6 comments
Open

Comments

@Steel5rat
Copy link

I'm trying to run sample boardzilla project on windows, and getting following error during npm install:
image

I suppose it's because it should use .zip extension for windows package. I believe such customization currently isn't supported in go-npm lib that you're using. I've created a PR joshbuddy/go-npm#1 to introduce it, so it would be nice to merge it, update go-npm lib, and change devtools goBinary.url to have a proper link for Windows.

@david-torres
Copy link

Same issue though it seems to be because there's no build for windows_amd64

@goodsky
Copy link

goodsky commented Feb 13, 2024

I found two additional issues:

  1. When installing using npm on Windows with a recent version of Node (18+) it will fail to detect the .bin directory. This PR addresses that issue: Use npm root to find directory to place .bin joshbuddy/go-npm#3
  2. The unzipper package is apparently broken with Node 20+ and causes the bz.exe file to be corrupt. This PR moves to use unzip-stream instead: Migrate to unzip-stream to avoid breaking change in unzipper joshbuddy/go-npm#4

@joshbuddy
Copy link
Contributor

Okay, I've got some news. Given the devtools are already just a go binary, I've decided to skip the middleman and ship that directly. If you could check out this link, and tell me if any of these methods are acceptable to you

https://docs.boardzilla.io/introduction/getting-started#installing-the-devtools

I could also enable winget, but want to hear from you first to see if that effort would be useful.

@goodsky
Copy link

goodsky commented Feb 13, 2024

That sounds reasonable to me (and more sustainable than fiddling with go-npm 🙂).

Of the options in the documentation, I will opt to build from source for now. At some point, I would expect a Windows installer to download. (In fact, I think having an installer may be a prerequisite for winget?). But I understand that being a low priority at the moment as long as we're unblocked.

@joshbuddy
Copy link
Contributor

Yeah, I think I'd like to support installers for every major platform, including Windows. Just need a couple of days to get it all ironed out. Glad you're unblocked

@joshbuddy
Copy link
Contributor

Okay, did a bunch more testing and fixes and Windows should be working now. Please let know if everything is good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants