Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a duplicated attribute in test262 results #788

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 4, 2020

This fixes a duplicate attribute name in the generated results for test262 tests.

@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. labels Oct 4, 2020
@Razican Razican added this to the v0.11.0 milestone Oct 4, 2020
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #788 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   59.13%   59.13%           
=======================================
  Files         155      155           
  Lines        9838     9838           
=======================================
  Hits         5818     5818           
  Misses       4020     4020           
Impacted Files Coverage Δ
boa_tester/src/main.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60d081...32b9a35. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 4, 2020

Benchmark for ff04836

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 382.8±6.81ns 362.4±7.77ns +5.63%
Arithmetic operations (Full) 255.0±4.88µs 256.3±10.31µs -0.51%
Array access (Execution) 7.8±0.14µs 7.9±0.13µs -1.27%
Array access (Full) 268.9±5.69µs 272.1±4.23µs -1.18%
Array creation (Execution) 3.3±0.05ms 3.3±0.06ms 0.00%
Array creation (Full) 3.6±0.07ms 3.6±0.06ms 0.00%
Array pop (Execution) 1192.8±24.07µs 1190.6±21.72µs +0.18%
Array pop (Full) 1643.6±22.25µs 1636.7±29.60µs +0.42%
Boolean Object Access (Execution) 4.8±0.12µs 4.9±0.07µs -2.04%
Boolean Object Access (Full) 258.5±6.12µs 262.4±6.08µs -1.49%
Clean js (Execution) 727.8±11.06µs 730.3±11.44µs -0.34%
Clean js (Full) 1041.9±37.14µs 1026.7±22.31µs +1.48%
Clean js (Parser) 34.7±0.60µs 34.7±0.59µs 0.00%
Create Realm 462.8±8.23ns 458.7±12.02ns +0.89%
Dynamic Object Property Access (Execution) 5.5±0.10µs 5.8±0.38µs -5.17%
Dynamic Object Property Access (Full) 267.1±5.84µs 263.1±5.20µs +1.52%
Expression (Parser) 6.7±0.09µs 6.7±0.10µs 0.00%
Fibonacci (Execution) 833.9±40.09µs 805.9±17.28µs +3.47%
Fibonacci (Full) 1119.5±34.00µs 1124.4±42.34µs -0.44%
For loop (Execution) 21.8±0.46µs 21.8±0.46µs 0.00%
For loop (Full) 281.9±7.71µs 287.3±5.90µs -1.88%
For loop (Parser) 17.2±0.28µs 17.0±0.26µs +1.18%
Goal Symbols (Parser) 11.5±0.22µs 11.6±0.23µs -0.86%
Hello World (Parser) 3.0±0.05µs 3.0±0.05µs 0.00%
Long file (Parser) 749.4±12.19ns 770.1±12.55ns -2.69%
Mini js (Execution) 654.9±11.14µs 647.7±12.19µs +1.11%
Mini js (Full) 942.7±17.01µs 943.6±14.30µs -0.10%
Mini js (Parser) 30.4±0.58µs 30.2±0.61µs +0.66%
Number Object Access (Execution) 3.9±0.08µs 3.9±0.05µs 0.00%
Number Object Access (Full) 260.3±4.64µs 266.1±12.26µs -2.18%
Object Creation (Execution) 4.6±0.09µs 4.6±0.10µs 0.00%
Object Creation (Full) 261.2±3.98µs 265.4±8.97µs -1.58%
RegExp (Execution) 64.6±1.12µs 64.0±1.47µs +0.94%
RegExp (Full) 344.0±5.48µs 339.9±7.77µs +1.21%
RegExp Literal (Execution) 66.6±2.08µs 68.3±3.06µs -2.49%
RegExp Literal (Full) 341.2±5.20µs 342.3±6.19µs -0.32%
RegExp Literal Creation (Execution) 63.5±1.54µs 63.9±1.93µs -0.63%
RegExp Literal Creation (Full) 335.0±5.46µs 338.0±6.13µs -0.89%
Static Object Property Access (Execution) 4.9±0.09µs 4.9±0.05µs 0.00%
Static Object Property Access (Full) 263.0±4.75µs 261.5±4.77µs +0.57%
String Object Access (Execution) 7.0±0.18µs 7.0±0.07µs 0.00%
String Object Access (Full) 267.1±4.46µs 264.6±4.40µs +0.94%
String comparison (Execution) 6.7±0.25µs 6.2±0.12µs +8.06%
String comparison (Full) 263.0±5.94µs 265.9±4.16µs -1.09%
String concatenation (Execution) 5.1±0.10µs 5.2±0.08µs -1.92%
String concatenation (Full) 260.8±4.44µs 255.7±4.68µs +1.99%
String copy (Execution) 3.9±0.07µs 3.9±0.08µs 0.00%
String copy (Full) 251.6±5.98µs 256.9±4.40µs -2.06%
Symbols (Execution) 3.3±0.05µs 3.2±0.06µs +3.12%
Symbols (Full) 265.3±10.62µs 251.7±3.73µs +5.40%

@Razican Razican merged commit 38b103c into master Oct 4, 2020
@Razican Razican deleted the fix_double_attr branch October 4, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants