Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new spec changes for AsyncGenerator #3950

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Conversation

jedel1043
Copy link
Member

Essentially the same as #3879 but supported by the latest specification.

@jedel1043 jedel1043 added bug Something isn't working Internal Category for changelog labels Aug 14, 2024
@jedel1043 jedel1043 added this to the next-release milestone Aug 14, 2024
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 48,212 48,476 +264
Passed 43,346 43,446 +100
Ignored 1,413 1,507 +94
Failed 3,453 3,523 +70
Panics 0 0 0
Conformance 89.91% 89.62% -0.28%
Broken tests (2):
test/harness/asyncHelpers-throwsAsync-func-throws-sync.js (previously Passed)
test/harness/asyncHelpers-throwsAsync-no-arg.js (previously Passed)

@jedel1043
Copy link
Member Author

jedel1043 commented Aug 15, 2024

Checked and the regressions are bugs in the test suite caused by recent changes to the asyncHelpers.js harness.

@jedel1043 jedel1043 marked this pull request as ready for review August 15, 2024 03:27
@jedel1043 jedel1043 requested a review from a team August 15, 2024 03:27
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Couple nits but they're non-blocking.

@nekevss nekevss requested a review from a team August 16, 2024 17:43
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good to me! :)

@jedel1043 jedel1043 added this pull request to the merge queue Aug 18, 2024
Merged via the queue into main with commit c22f39b Aug 18, 2024
13 checks passed
@jedel1043 jedel1043 deleted the new-async-generator branch August 18, 2024 04:45
jedel1043 added a commit that referenced this pull request Sep 11, 2024
* Implement new spec changes for `AsyncGenerator`

* Add panic docs
raskad pushed a commit that referenced this pull request Sep 11, 2024
* Implement new spec changes for `AsyncGenerator` (#3950)

* Implement new spec changes for `AsyncGenerator`

* Add panic docs

* Add spec edition 15 to the tester (#3957)

* Allow dead code for code that is newly detected as unused (#3984)

* Allow dead code for code that is newly detected as unused

* Fix compile errors with nightly rust

* Add missing SAFETY section

* Increase safety of `FutexWaiters`

---------

Co-authored-by: Theo Paris <[email protected]>
Co-authored-by: José Julián Espina <[email protected]>

* Enable CI for release branches (#3987)

* Allow warnings when running CI on release branches (#3990)

* Bump crates version

---------

Co-authored-by: Hans Larsen <[email protected]>
Co-authored-by: Theo Paris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants