From 880511f2d8b312756ed8eb8a12cfb99ca3638658 Mon Sep 17 00:00:00 2001 From: Iban Eguia Moraza Date: Wed, 20 Sep 2023 21:38:00 +0200 Subject: [PATCH 1/3] Added MSRV check --- .github/workflows/rust.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 02dc41596dd..23e6405a578 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -66,6 +66,20 @@ jobs: - name: Test docs run: cargo test --doc --profile ci --features intl + msrv: + name: Minimum supported Rust version + runs-on: ubuntu-latest + timeout-minutes: 60 + steps: + - uses: actions/checkout@v4 + - uses: actions-rs/toolchain@v1.0.7 + with: + toolchain: "1.71.0" + override: true + profile: minimal + - name: Check compilation + run: cargo check --all-features --all-targets + misc: name: Misc runs-on: ubuntu-latest From 2f217c39b8b8766cea4a99e25a50e8ef2d2f74f4 Mon Sep 17 00:00:00 2001 From: Iban Eguia Moraza Date: Sat, 23 Sep 2023 13:23:44 +0200 Subject: [PATCH 2/3] Added Rust version check from Cargo.toml --- .github/workflows/rust.yml | 6 +++++- Cargo.toml | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 23e6405a578..cedeeebd8cc 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -72,9 +72,13 @@ jobs: timeout-minutes: 60 steps: - uses: actions/checkout@v4 + # Get the rust_version from the Cargo.toml + - name: Get rust_version + id: rust_version + run: echo "::set-output name=rust_version::$(grep '^rust-version' Cargo.toml | cut -d' ' -f3 | tr -d '"')" - uses: actions-rs/toolchain@v1.0.7 with: - toolchain: "1.71.0" + toolchain: ${{ steps.rust_version.outputs.rust_version }} override: true profile: minimal - name: Check compilation diff --git a/Cargo.toml b/Cargo.toml index 7bdf9123fc8..541539ae2e2 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,7 +20,7 @@ members = [ [workspace.package] edition = "2021" version = "0.17.0" -rust-version = "1.71" +rust-version = "1.71.0" authors = ["boa-dev"] repository = "https://github.com/boa-dev/boa" license = "Unlicense OR MIT" From 37e054746fd361ab3b80fa92e206f3da903d4a04 Mon Sep 17 00:00:00 2001 From: Iban Eguia Moraza Date: Sat, 23 Sep 2023 23:37:37 +0200 Subject: [PATCH 3/3] Update rust.yml Co-authored-by: Kevin <46825870+nekevss@users.noreply.github.com> --- .github/workflows/rust.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index cedeeebd8cc..4ee2dc64606 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -75,7 +75,7 @@ jobs: # Get the rust_version from the Cargo.toml - name: Get rust_version id: rust_version - run: echo "::set-output name=rust_version::$(grep '^rust-version' Cargo.toml | cut -d' ' -f3 | tr -d '"')" + run: echo "rust_version=$(grep '^rust-version' Cargo.toml | cut -d' ' -f3 | tr -d '"')" >> $GITHUB_OUTPUT - uses: actions-rs/toolchain@v1.0.7 with: toolchain: ${{ steps.rust_version.outputs.rust_version }}