From 6bb75b47a8ce2c635e2acfe0d139bc2521af6f51 Mon Sep 17 00:00:00 2001 From: Veera Date: Tue, 9 May 2023 21:02:05 -0400 Subject: [PATCH 1/2] Check if es6id is found --- boa_tester/src/edition.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boa_tester/src/edition.rs b/boa_tester/src/edition.rs index 8ad0ba873fc..1ace14b16e7 100644 --- a/boa_tester/src/edition.rs +++ b/boa_tester/src/edition.rs @@ -341,7 +341,7 @@ impl SpecEdition { pub(crate) fn from_test_metadata(metadata: &MetaData) -> Result> { let mut min_edition = if metadata.flags.contains(&TestFlag::Async) { Self::ES8 - } else if metadata.flags.contains(&TestFlag::Module) { + } else if metadata.flags.contains(&TestFlag::Module) || metadata.es6id.is_some() { Self::ES6 } else { Self::ES5 From e5f62ec5d92c718c01634c67000c697cf62f4abf Mon Sep 17 00:00:00 2001 From: Veera Date: Wed, 10 May 2023 10:49:02 -0400 Subject: [PATCH 2/2] Check for both esid and es6id --- boa_tester/src/edition.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/boa_tester/src/edition.rs b/boa_tester/src/edition.rs index 1ace14b16e7..aafb18eb4c6 100644 --- a/boa_tester/src/edition.rs +++ b/boa_tester/src/edition.rs @@ -341,7 +341,10 @@ impl SpecEdition { pub(crate) fn from_test_metadata(metadata: &MetaData) -> Result> { let mut min_edition = if metadata.flags.contains(&TestFlag::Async) { Self::ES8 - } else if metadata.flags.contains(&TestFlag::Module) || metadata.es6id.is_some() { + } else if metadata.flags.contains(&TestFlag::Module) + || metadata.esid.is_some() + || metadata.es6id.is_some() + { Self::ES6 } else { Self::ES5