From 6f1ca340c0b8f5a468c4863a4df11dc5ad10e1bc Mon Sep 17 00:00:00 2001 From: nekevss Date: Wed, 1 Feb 2023 21:24:49 -0500 Subject: [PATCH 1/2] Feature flag on builtins console import --- boa_engine/src/builtins/mod.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/boa_engine/src/builtins/mod.rs b/boa_engine/src/builtins/mod.rs index 0263361adc9..d31b6d7feb9 100644 --- a/boa_engine/src/builtins/mod.rs +++ b/boa_engine/src/builtins/mod.rs @@ -86,7 +86,6 @@ use crate::{ uri::{DecodeUri, DecodeUriComponent, EncodeUri, EncodeUriComponent}, weak::WeakRef, }, - console::Console, context::intrinsics::{Intrinsics, StandardConstructor, StandardConstructors}, js_string, native_function::{NativeFunction, NativeFunctionPointer}, @@ -97,6 +96,9 @@ use crate::{ Context, JsResult, JsString, JsValue, }; +#[cfg(feature = "console")] +use crate::console::Console; + /// A [Well-Known Intrinsic Object]. /// /// Well-known intrinsics are built-in objects that are explicitly referenced by the algorithms of From 8b39952c3e22ac3574af93e0c1f353edec2e0569 Mon Sep 17 00:00:00 2001 From: nekevss Date: Thu, 2 Feb 2023 09:49:32 -0500 Subject: [PATCH 2/2] Modify Lint (No features) --- .github/workflows/rust.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 5665c1b04c7..475e6b5e775 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -77,7 +77,7 @@ jobs: - name: Lint (All features) run: cargo clippy --all-features --all-targets - name: Lint (No features) - run: cargo clippy --no-default-features --all-targets + run: cargo clippy -p boa_engine --no-default-features --all-targets - name: Generate documentation run: cargo doc -v --document-private-items --all-features - name: Build