Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement JsRegExp #2326

Closed
wants to merge 8 commits into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Oct 8, 2022

This Pull Request is related to #2098.

It changes the following:

  • Implements JsRegExp
  • Adds a brief JsRegExp example under boa_examples

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #2326 (1357af0) into main (df70302) will decrease coverage by 0.13%.
The diff coverage is 2.85%.

@@            Coverage Diff             @@
##             main    #2326      +/-   ##
==========================================
- Coverage   40.82%   40.69%   -0.14%     
==========================================
  Files         240      241       +1     
  Lines       22743    22811      +68     
==========================================
- Hits         9285     9283       -2     
- Misses      13458    13528      +70     
Impacted Files Coverage Δ
boa_engine/src/object/builtins/jsregexp.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/regexp/mod.rs 66.13% <100.00%> (ø)
boa_engine/src/syntax/ast/node/spread/mod.rs 57.14% <0.00%> (-14.29%) ⬇️
...a_engine/src/syntax/ast/node/statement_list/mod.rs 78.12% <0.00%> (-3.13%) ⬇️
...ntax/parser/expression/left_hand_side/arguments.rs 35.00% <0.00%> (-2.50%) ⬇️
boa_engine/src/syntax/parser/expression/unary.rs 47.16% <0.00%> (-1.89%) ⬇️
...parser/expression/primary/array_initializer/mod.rs 38.88% <0.00%> (-1.86%) ⬇️
...ine/src/syntax/parser/expression/assignment/mod.rs 52.42% <0.00%> (+0.97%) ⬆️
boa_engine/src/syntax/ast/node/template/mod.rs 50.00% <0.00%> (+3.33%) ⬆️
...c/syntax/ast/node/declaration/function_decl/mod.rs 57.89% <0.00%> (+5.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043
Copy link
Member

Thank you!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 15, 2022
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request is related to #2098.

It changes the following:

- Implements `JsRegExp`
- Adds a brief `JsRegExp` example under `boa_examples`
@bors
Copy link

bors bot commented Oct 15, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement JsRegExp [Merged by Bors] - Implement JsRegExp Oct 15, 2022
@bors bors bot closed this Oct 15, 2022
@Razican Razican added API builtins PRs and Issues related to builtins/intrinsics hacktoberfest-accepted PR accepted for Hacktoberfest labels Oct 15, 2022
@RageKnify RageKnify added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants