Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement AggregateError #1888

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement AggregateError #1888

wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Implement AggregateError global object

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Mar 2, 2022
@HalidOdat HalidOdat added this to the v0.14.0 milestone Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022 •
edited
Loading

Codecov Report

Merging #1888 (3e7ba54) into main (fb8c5cf) will increase coverage by 0.10%.
The diff coverage is 23.80%.

❗ Current head 3e7ba54 differs from pull request most recent head 897bee9. Consider uploading reports for the commit 897bee9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
+ Coverage   46.59%   46.69%   +0.10%     
==========================================
  Files         205      205              
  Lines       16753    16791      +38     
==========================================
+ Hits         7806     7841      +35     
- Misses       8947     8950       +3
Impacted Files Coverage Δ
boa_engine/src/builtins/error/mod.rs 90.00% <ø> (ø)
boa_engine/src/builtins/iterable/mod.rs 41.11% <0.00%> (-7.91%) ⬇️
boa_engine/src/builtins/mod.rs 11.47% <0.00%> (-0.20%) ⬇️
boa_engine/src/builtins/error/aggregate.rs 42.10% <42.10%> (ø)
boa_engine/src/context.rs 46.08% <66.66%> (+0.18%) ⬆️
boa_engine/src/builtins/global_this/mod.rs 50.00% <0.00%> (-50.00%) ⬇️
...engine/src/syntax/parser/expression/primary/mod.rs 34.37% <0.00%> (-3.13%) ⬇️
boa_engine/src/value/mod.rs 51.22% <0.00%> (-0.26%) ⬇️
boa_engine/src/vm/mod.rs 70.69% <0.00%> (-0.25%) ⬇️
boa_engine/src/builtins/map/mod.rs 84.94% <0.00%> (-0.17%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8c5cf...897bee9. Read the comment docs.

@HalidOdat HalidOdat marked this pull request as draft March 2, 2022 16:03
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Benchmark for 311dc87

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 581.9±14.40ns 566.5±31.68ns -2.65%
Arithmetic operations (Execution) 2.3±0.04µs 2.0±0.11µs -13.04%
Arithmetic operations (Parser) 5.0±0.32µs 4.9±0.24µs -2.00%
Array access (Compiler) 1466.3±28.39ns 1432.2±50.63ns -2.33%
Array access (Execution) 11.3±0.20µs 10.1±0.66µs -10.62%
Array access (Parser) 12.5±0.20µs 12.2±0.76µs -2.40%
Array creation (Compiler) 2.1±0.04µs 1834.9±120.26ns -12.62%
Array creation (Execution) 3.7±0.06ms 3.4±0.18ms -8.11%
Array creation (Parser) 13.0±0.52µs 13.2±0.63µs +1.54%
Array pop (Compiler) 4.6±0.14µs 3.9±0.27µs -15.22%
Array pop (Execution) 1620.7±28.79µs 1497.7±75.34µs -7.59%
Array pop (Parser) 128.0±6.63µs 145.4±7.36µs +13.59%
Boolean Object Access (Compiler) 1147.8±27.78ns 1015.7±57.18ns -11.51%
Boolean Object Access (Execution) 6.6±0.23µs 5.9±0.35µs -10.61%
Boolean Object Access (Parser) 13.8±0.76µs 14.0±0.74µs +1.45%
Clean js (Compiler) 3.8±0.07µs 3.4±0.20µs -10.53%
Clean js (Execution) 1267.9±27.29µs 1098.9±62.39µs -13.33%
Clean js (Parser) 27.0±1.58µs 26.7±1.44µs -1.11%
Create Realm 279.8±14.55ns 280.6±19.38ns +0.29%
Dynamic Object Property Access (Compiler) 1868.2±34.60ns 1596.9±82.61ns -14.52%
Dynamic Object Property Access (Execution) 7.7±0.19µs 7.1±0.34µs -7.79%
Dynamic Object Property Access (Parser) 9.5±0.51µs 10.4±0.38µs +9.47%
Fibonacci (Compiler) 2.6±0.04µs 2.2±0.12µs -15.38%
Fibonacci (Execution) 2.1±0.04ms 1771.4±97.23µs -15.65%
Fibonacci (Parser) 15.1±0.87µs 15.9±0.56µs +5.30%
For loop (Compiler) 2.3±0.05µs 1908.6±88.99ns -17.02%
For loop (Execution) 48.2±1.06µs 43.5±2.26µs -9.75%
For loop (Parser) 12.5±0.70µs 13.4±0.80µs +7.20%
Mini js (Compiler) 3.6±0.12µs 3.2±0.15µs -11.11%
Mini js (Execution) 1165.1±21.93µs 1010.8±58.07µs -13.24%
Mini js (Parser) 23.3±1.07µs 22.9±1.06µs -1.72%
Number Object Access (Compiler) 1082.1±26.17ns 964.5±59.50ns -10.87%
Number Object Access (Execution) 5.2±0.10µs 4.8±0.25µs -7.69%
Number Object Access (Parser) 10.4±0.46µs 11.3±0.43µs +8.65%
Object Creation (Compiler) 1620.4±35.29ns 1375.8±71.84ns -15.10%
Object Creation (Execution) 7.1±0.19µs 6.0±0.33µs -15.49%
Object Creation (Parser) 8.9±0.38µs 8.8±0.36µs -1.12%
RegExp (Compiler) 1876.4±38.24ns 1614.9±76.50ns -13.94%
RegExp (Execution) 14.1±0.24µs 12.4±0.66µs -12.06%
RegExp (Parser) 9.9±0.58µs 9.5±0.49µs -4.04%
RegExp Creation (Compiler) 1640.6±30.68ns 1553.5±100.58ns -5.31%
RegExp Creation (Execution) 10.4±0.24µs 9.3±0.36µs -10.58%
RegExp Creation (Parser) 7.7±0.37µs 7.8±0.45µs +1.30%
RegExp Literal (Compiler) 1863.3±39.07ns 1720.6±97.45ns -7.66%
RegExp Literal (Execution) 14.0±0.28µs 12.4±0.73µs -11.43%
RegExp Literal (Parser) 7.2±0.38µs 7.8±0.44µs +8.33%
RegExp Literal Creation (Compiler) 1618.3±36.11ns 1490.5±83.79ns -7.90%
RegExp Literal Creation (Execution) 10.4±0.20µs 9.1±0.64µs -12.50%
RegExp Literal Creation (Parser) 5.8±0.31µs 6.1±0.27µs +5.17%
Static Object Property Access (Compiler) 1714.1±20.11ns 1426.9±67.38ns -16.76%
Static Object Property Access (Execution) 7.3±0.19µs 6.3±0.34µs -13.70%
Static Object Property Access (Parser) 9.2±0.50µs 9.8±0.33µs +6.52%
String Object Access (Compiler) 1562.7±32.72ns 1366.5±74.61ns -12.56%
String Object Access (Execution) 9.3±0.15µs 7.8±0.49µs -16.13%
String Object Access (Parser) 13.7±0.68µs 13.2±0.59µs -3.65%
String comparison (Compiler) 2.4±0.06µs 2.0±0.10µs -16.67%
String comparison (Execution) 6.6±0.19µs 6.1±0.27µs -7.58%
String comparison (Parser) 10.2±0.50µs 10.8±0.55µs +5.88%
String concatenation (Compiler) 1860.1±48.59ns 1705.4±114.63ns -8.32%
String concatenation (Execution) 6.1±0.18µs 5.5±0.28µs -9.84%
String concatenation (Parser) 7.0±0.32µs 7.1±0.44µs +1.43%
String copy (Compiler) 1472.7±34.68ns 1289.4±59.78ns -12.45%
String copy (Execution) 5.5±0.13µs 5.0±0.24µs -9.09%
String copy (Parser) 5.3±0.24µs 5.6±0.39µs +5.66%
Symbols (Compiler) 992.4±76.63ns 904.6±47.75ns -8.85%
Symbols (Execution) 5.1±0.12µs 4.4±0.25µs -13.73%
Symbols (Parser) 4.0±0.16µs 3.8±0.20µs -5.00%

@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 88,342 88,342 0
Passed 43,233 43,283 +50
Ignored 21,413 21,413 0
Failed 23,696 23,646 -50
Panics 0 0 0
Conformance 48.94% 48.99% +0.06%
Fixed tests (50): 
test/built-ins/NativeErrors/AggregateError/prop-desc.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/prop-desc.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-tostring-abrupt.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-tostring-abrupt.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/cause-property.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/cause-property.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/newtarget-proto.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/newtarget-proto.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/newtarget-proto-fallback.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/newtarget-proto-fallback.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/errors-iterabletolist.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/errors-iterabletolist.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-tostring-abrupt-symbol.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-tostring-abrupt-symbol.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/name.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/name.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/is-a-constructor.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/is-a-constructor.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/order-of-args-evaluation.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/order-of-args-evaluation.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/proto-from-ctor-realm.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/proto-from-ctor-realm.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-method-prop-cast.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-method-prop-cast.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/newtarget-proto-custom.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/newtarget-proto-custom.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-method-prop.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-method-prop.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-undefined-no-prop.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/message-undefined-no-prop.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/proto.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/proto.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/newtarget-is-undefined.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/newtarget-is-undefined.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/errors-iterabletolist-failures.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/errors-iterabletolist-failures.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/constructor.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/constructor.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/prop-desc.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/prop-desc.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/name.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/name.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/message.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/message.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/errors-absent-on-prototype.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/errors-absent-on-prototype.js (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/proto.js [strict mode] (previously Failed)
test/built-ins/NativeErrors/AggregateError/prototype/proto.js (previously Failed)
test/built-ins/Object/seal/seal-aggregateerror.js [strict mode] (previously Failed)
test/built-ins/Object/seal/seal-aggregateerror.js (previously Failed)

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Benchmark for 552f1b4

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 513.6±3.82ns 516.7±1.91ns +0.60%
Arithmetic operations (Execution) 1989.7±3.16ns 1916.1±2.77ns -3.70%
Arithmetic operations (Parser) 5.2±0.00µs 5.2±0.00µs 0.00%
Array access (Compiler) 1275.8±3.12ns 1256.1±2.55ns -1.54%
Array access (Execution) 9.9±0.09µs 9.7±0.09µs -2.02%
Array access (Parser) 11.5±0.02µs 11.5±0.02µs 0.00%
Array creation (Compiler) 1833.8±4.29ns 1792.9±7.63ns -2.23%
Array creation (Execution) 3.2±0.01ms 3.3±0.01ms +3.13%
Array creation (Parser) 12.9±0.02µs 12.9±0.03µs 0.00%
Array pop (Compiler) 4.0±0.00µs 3.8±0.01µs -5.00%
Array pop (Execution) 1380.1±2.89µs 1412.7±12.36µs +2.36%
Array pop (Parser) 129.3±0.08µs 129.8±0.12µs +0.39%
Boolean Object Access (Compiler) 1105.2±3.82ns 1094.8±2.99ns -0.94%
Boolean Object Access (Execution) 5.7±0.02µs 5.7±0.03µs 0.00%
Boolean Object Access (Parser) 14.1±0.01µs 13.7±0.01µs -2.84%
Clean js (Compiler) 3.4±0.01µs 3.3±0.01µs -2.94%
Clean js (Execution) 1089.6±5.28µs 1100.0±13.75µs +0.95%
Clean js (Parser) 28.0±0.03µs 27.9±0.14µs -0.36%
Create Realm 272.7±0.45ns 266.9±0.30ns -2.13%
Dynamic Object Property Access (Compiler) 1628.2±4.60ns 1575.0±2.91ns -3.27%
Dynamic Object Property Access (Execution) 6.8±0.04µs 6.7±0.03µs -1.47%
Dynamic Object Property Access (Parser) 10.3±0.02µs 10.3±0.01µs 0.00%
Fibonacci (Compiler) 2.2±0.00µs 2.3±0.01µs +4.55%
Fibonacci (Execution) 1757.2±2.82µs 1739.7±11.68µs -1.00%
Fibonacci (Parser) 15.6±0.09µs 15.7±0.02µs +0.64%
For loop (Compiler) 1967.0±6.58ns 1911.3±5.13ns -2.83%
For loop (Execution) 42.2±1.78µs 41.7±0.12µs -1.18%
For loop (Parser) 13.3±0.03µs 13.4±0.03µs +0.75%
Mini js (Compiler) 3.3±0.01µs 3.2±0.01µs -3.03%
Mini js (Execution) 998.7±4.05µs 1003.7±5.16µs +0.50%
Mini js (Parser) 24.5±0.02µs 24.5±0.04µs 0.00%
Number Object Access (Compiler) 1039.9±4.79ns 1043.4±3.83ns +0.34%
Number Object Access (Execution) 4.5±0.01µs 4.5±0.02µs 0.00%
Number Object Access (Parser) 10.9±0.02µs 10.8±0.01µs -0.92%
Object Creation (Compiler) 1381.4±6.41ns 1365.9±7.94ns -1.12%
Object Creation (Execution) 6.1±0.02µs 6.1±0.02µs 0.00%
Object Creation (Parser) 8.9±0.01µs 8.9±0.02µs 0.00%
RegExp (Compiler) 1636.2±7.26ns 1594.4±2.07ns -2.55%
RegExp (Execution) 12.1±0.06µs 12.7±0.03µs +4.96%
RegExp (Parser) 9.9±0.02µs 9.8±0.02µs -1.01%
RegExp Creation (Compiler) 1419.5±6.98ns 1368.0±4.66ns -3.63%
RegExp Creation (Execution) 9.0±0.03µs 9.5±0.05µs +5.56%
RegExp Creation (Parser) 8.2±0.02µs 8.1±0.04µs -1.22%
RegExp Literal (Compiler) 1631.3±8.48ns 1593.9±3.82ns -2.29%
RegExp Literal (Execution) 12.2±0.06µs 12.5±0.04µs +2.46%
RegExp Literal (Parser) 8.0±0.01µs 7.9±0.03µs -1.25%
RegExp Literal Creation (Compiler) 1426.6±6.86ns 1379.6±8.44ns -3.29%
RegExp Literal Creation (Execution) 9.0±0.03µs 9.6±0.05µs +6.67%
RegExp Literal Creation (Parser) 6.3±0.02µs 6.3±0.01µs 0.00%
Static Object Property Access (Compiler) 1386.1±6.24ns 1393.4±5.82ns +0.53%
Static Object Property Access (Execution) 6.5±0.02µs 6.3±0.02µs -3.08%
Static Object Property Access (Parser) 9.6±0.02µs 9.6±0.02µs 0.00%
String Object Access (Compiler) 1475.9±4.71ns 1449.9±5.00ns -1.76%
String Object Access (Execution) 7.7±0.05µs 7.6±0.03µs -1.30%
String Object Access (Parser) 13.8±0.01µs 13.5±0.01µs -2.17%
String comparison (Compiler) 2.1±0.01µs 2.0±0.00µs -4.76%
String comparison (Execution) 5.9±0.03µs 5.9±0.02µs 0.00%
String comparison (Parser) 10.6±0.02µs 10.5±0.02µs -0.94%
String concatenation (Compiler) 1626.1±7.93ns 1617.6±3.03ns -0.52%
String concatenation (Execution) 5.3±0.02µs 5.3±0.02µs 0.00%
String concatenation (Parser) 7.3±0.02µs 7.3±0.01µs 0.00%
String copy (Compiler) 1299.5±3.06ns 1285.7±6.12ns -1.06%
String copy (Execution) 4.7±0.02µs 4.7±0.02µs 0.00%
String copy (Parser) 5.5±0.02µs 5.4±0.01µs -1.82%
Symbols (Compiler) 914.7±1.88ns 907.7±3.35ns -0.77%
Symbols (Execution) 4.5±0.01µs 4.5±0.01µs 0.00%
Symbols (Parser) 4.3±0.02µs 4.2±0.01µs -2.33%

@HalidOdat HalidOdat added the blocked Waiting for another code change label Mar 2, 2022
@HalidOdat
Copy link
Member Author

Blocked until #1889 , gets merged

@HalidOdat HalidOdat removed the blocked Waiting for another code change label Mar 3, 2022
@HalidOdat HalidOdat marked this pull request as ready for review March 3, 2022 08:58
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Benchmark for 588c102

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 505.9±0.68ns 512.3±1.74ns +1.27%
Arithmetic operations (Execution) 1958.6±3.10ns 1998.1±1.76ns +2.02%
Arithmetic operations (Parser) 5.2±0.01µs 5.2±0.01µs 0.00%
Array access (Compiler) 1250.6±3.56ns 1251.8±2.80ns +0.10%
Array access (Execution) 9.8±0.05µs 9.7±0.13µs -1.02%
Array access (Parser) 11.5±0.02µs 11.6±0.02µs +0.87%
Array creation (Compiler) 1822.6±4.82ns 1825.1±4.07ns +0.14%
Array creation (Execution) 3.2±0.01ms 3.1±0.00ms -3.13%
Array creation (Parser) 13.0±0.01µs 12.9±0.02µs -0.77%
Array pop (Compiler) 3.9±0.01µs 3.8±0.01µs -2.56%
Array pop (Execution) 1409.5±66.64µs 1366.4±17.83µs -3.06%
Array pop (Parser) 130.0±0.11µs 129.2±0.14µs -0.62%
Boolean Object Access (Compiler) 1100.8±6.84ns 1095.8±3.60ns -0.45%
Boolean Object Access (Execution) 5.8±0.02µs 5.7±0.01µs -1.72%
Boolean Object Access (Parser) 14.3±0.01µs 13.8±0.01µs -3.50%
Clean js (Compiler) 3.3±0.01µs 3.3±0.01µs 0.00%
Clean js (Execution) 1091.0±7.74µs 1089.6±10.46µs -0.13%
Clean js (Parser) 28.0±0.02µs 27.9±0.02µs -0.36%
Create Realm 268.0±0.48ns 271.0±0.65ns +1.12%
Dynamic Object Property Access (Compiler) 1581.0±2.90ns 1585.3±3.10ns +0.27%
Dynamic Object Property Access (Execution) 6.7±0.03µs 6.7±0.03µs 0.00%
Dynamic Object Property Access (Parser) 10.3±0.02µs 10.2±0.02µs -0.97%
Fibonacci (Compiler) 2.2±0.01µs 2.2±0.00µs 0.00%
Fibonacci (Execution) 1770.5±2.57µs 1754.4±3.25µs -0.91%
Fibonacci (Parser) 15.7±0.02µs 15.8±0.05µs +0.64%
For loop (Compiler) 1919.7±4.22ns 1952.1±46.79ns +1.69%
For loop (Execution) 42.0±0.11µs 42.5±0.11µs +1.19%
For loop (Parser) 13.3±0.02µs 13.5±0.01µs +1.50%
Mini js (Compiler) 3.2±0.01µs 3.2±0.01µs 0.00%
Mini js (Execution) 1003.9±5.98µs 995.3±5.85µs -0.86%
Mini js (Parser) 24.6±0.05µs 24.3±0.03µs -1.22%
Number Object Access (Compiler) 1044.1±6.06ns 1033.6±2.25ns -1.01%
Number Object Access (Execution) 4.5±0.01µs 4.4±0.01µs -2.22%
Number Object Access (Parser) 11.0±0.02µs 10.9±0.02µs -0.91%
Object Creation (Compiler) 1360.1±6.46ns 1377.5±5.88ns +1.28%
Object Creation (Execution) 6.0±0.02µs 6.0±0.02µs 0.00%
Object Creation (Parser) 9.0±0.01µs 8.9±0.01µs -1.11%
RegExp (Compiler) 1592.3±2.92ns 1591.5±19.63ns -0.05%
RegExp (Execution) 12.7±0.04µs 12.6±0.03µs -0.79%
RegExp (Parser) 9.8±0.01µs 9.7±0.02µs -1.02%
RegExp Creation (Compiler) 1374.4±6.70ns 1393.8±4.53ns +1.41%
RegExp Creation (Execution) 9.5±0.04µs 9.3±0.04µs -2.11%
RegExp Creation (Parser) 8.3±0.02µs 8.2±0.02µs -1.20%
RegExp Literal (Compiler) 1595.7±2.46ns 1576.4±2.83ns -1.21%
RegExp Literal (Execution) 12.6±0.04µs 12.4±0.03µs -1.59%
RegExp Literal (Parser) 7.9±0.01µs 7.9±0.09µs 0.00%
RegExp Literal Creation (Compiler) 1350.1±4.38ns 1381.4±5.81ns +2.32%
RegExp Literal Creation (Execution) 9.4±0.04µs 9.3±0.03µs -1.06%
RegExp Literal Creation (Parser) 6.3±0.01µs 6.2±0.01µs -1.59%
Static Object Property Access (Compiler) 1380.7±5.43ns 1379.7±5.84ns -0.07%
Static Object Property Access (Execution) 6.3±0.02µs 6.3±0.03µs 0.00%
Static Object Property Access (Parser) 9.7±0.02µs 9.6±0.05µs -1.03%
String Object Access (Compiler) 1454.5±9.15ns 1449.2±8.00ns -0.36%
String Object Access (Execution) 7.4±0.02µs 7.5±0.03µs +1.35%
String Object Access (Parser) 13.9±0.01µs 13.6±0.02µs -2.16%
String comparison (Compiler) 2.0±0.01µs 2.1±0.01µs +5.00%
String comparison (Execution) 5.8±0.01µs 5.8±0.02µs 0.00%
String comparison (Parser) 10.6±0.02µs 10.5±0.01µs -0.94%
String concatenation (Compiler) 1620.1±4.12ns 1592.7±2.15ns -1.69%
String concatenation (Execution) 5.3±0.02µs 5.2±0.01µs -1.89%
String concatenation (Parser) 7.3±0.01µs 7.3±0.01µs 0.00%
String copy (Compiler) 1258.7±7.69ns 1271.4±2.87ns +1.01%
String copy (Execution) 4.7±0.02µs 4.7±0.02µs 0.00%
String copy (Parser) 5.5±0.01µs 5.4±0.01µs -1.82%
Symbols (Compiler) 891.5±1.73ns 887.1±1.22ns -0.49%
Symbols (Execution) 4.5±0.01µs 4.4±0.01µs -2.22%
Symbols (Parser) 4.3±0.01µs 4.2±0.01µs -2.33%

@raskad
Copy link
Member

raskad commented Mar 3, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 3, 2022
@HalidOdat
Implement AggregateError (#1888)
4c3058b 
It changes the following:
- Implement `AggregateError` global object
@bors
Copy link

bors bot commented Mar 3, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement AggregateError [Merged by Bors] - Implement AggregateError Mar 3, 2022
@bors bors bot closed this Mar 3, 2022
@bors bors bot deleted the feature/AggregateError branch March 3, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@raskad raskad raskad approved these changes

@Razican Razican Awaiting requested review from Razican

@RageKnify RageKnify Awaiting requested review from RageKnify

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @raskad @jedel1043